-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #280
base: main
Are you sure you want to change the base?
Add release workflow #280
Conversation
Signed-off-by: Adam Korczynski <[email protected]>
@haydentherapper Could you have a look? |
This was intentional to only release source code archives. We want to discourage users using the sigstore-go CLIs - they are meant as examples for signing and verification. I'd say we only need a provenance attestation on how the source archive was built. |
I would also not recommend releasing any binaries by the reason @haydentherapper mentions. |
Signed-off-by: Adam Korczynski <[email protected]> Generates provenance for the source archives that users can download.
Current status with c3d757f Sample run: https://github.com/AdamKorcz/test-releasing/actions/runs/10564714125 I have adjusted the workflow so that it generates verifiable provenance for the compressed sigstore-go source archives. The interoperability between the compressed source archives and https://github.com/actions/attest-build-provenance is not great (although there are many good things to say about https://github.com/actions/attest-build-provenance), so I've had to do some workarounds. The following areas lack support to make generating provenance for source archives simpler:
Verifying provenanceWith the current state of the workflow, users can download the sigstore-go source archives by any of the following ways and verify them. These are tested out on my own repo, so I am adding reproducible steps that succesfully verify. With the workflow in sigstore-go's own repo, the links would be
Method 1:
|
@haydentherapper @kommendorkapten I am keeping this in draft, but could you consider c3d757f and #280 (comment) |
Summary
This adds a GitHub workflow for releasing the sigstore-go source code and provenance attestation.
For current status on this PR, see #280 (comment)
Old intro below kept for tracking. See #280 (comment) for current status
Sample run: https://github.com/AdamKorcz/sigstore-go/actions/runs/10516249552
I have made a few decisions that need consideration:
make test
or should that be a separate workflow?dispatch
orpush
.The windows runner is giving me some problems which is why I am hardcoding the binary name:
It could be refactored to look nicer.
Release Note
Documentation